Ivor Wanders

Results 116 comments of Ivor Wanders

Ah excellent news! Glad we don't need to sprinkle if-statements! :tada:

Yeah, cherrypicked that into my dev repo (edits to work around lack of `thermal_tripless_zone_device_register` >_

Took a crack at it; https://github.com/linux-surface/surface-aggregator-module/pull/68 The duplicates do make me worry a bit whether it's really the name, or just a string... :/

Just capturing this here, I came across the following id's in the `SurfaceDiagnosticToolkit_SDT4B.exe` binary (from the business diagnostic toolkit found [here](https://www.microsoft.com/en-us/download/details.aspx?id=46703)) when looked at with [ilspy](https://github.com/icsharpcode/ILSpy). ``` TouchTemperature2 = 12;...

> With this setup i had other library witch work at the same pinrx 16 and tx 17 Do you know which protocol was used by that library? What library...

> I had 2 libraries one with kwp2000 and other with 9141-2 , both works very slow and intrerrupt my lcd display data. Both use 5-baud. This library is also...

> Must this library work with mc33290 too , right? Certainly, I've used that chip myself with this library. > I comment the line 386 and nothing happen Looks like...

Thanks for sharing code and prints. I put some backticks (`) in your comment to create code blocks to make it more readable. > OBD9141println(serial_port); I don't think that print...

> How can we see if the serial2 is correct init? Not sure if there's any way... :/ Start by putting a [print here](https://github.com/iwanders/OBD9141/blob/1d07f979494d19714d1e0d9bb96d48c1ce4adb8f/src/OBD9141.cpp#L31) to print the pin numbers that...

Hmm, well, the ECU is clearly not talking back. The first read isn't even `252` anymore like it was before. The hardware is the exact same as in [this comment](https://github.com/iwanders/OBD9141/issues/45#issuecomment-1435493682)?...