docker-minecraft-server icon indicating copy to clipboard operation
docker-minecraft-server copied to clipboard

Allow to download plugins from Modrinth like spiget

Open theo546 opened this issue 3 years ago • 4 comments

Enhancement Type

A completely new feature

Describe the enhancement

As of now, Modrinth now allow the download of plugins for any Bukkit/Spigot/Paper server, which is awesome, and could be integrated like spiget already is.

You can see a page full of plugins from the Modrinth website here: https://modrinth.com/plugins

As a bonus point, what about being able to use both SPIGET_RESOURCES and a new MODRINTH_RESOURCES environnement variable at the same time?

theo546 avatar Jan 02 '23 16:01 theo546

Good news: it's already supported

https://github.com/itzg/docker-minecraft-server#auto-download-mods-from-modrinth

itzg avatar Jan 02 '23 17:01 itzg

Is not only for mods?

theo546 avatar Jan 02 '23 17:01 theo546

I think they call them "projects": mods, plugins, whatever.

Did you try the feature and it didn't work for you?

itzg avatar Jan 02 '23 17:01 itzg

I just tried with the following env variables, it doesn't download anything:

      VERSION: "1.19.3"
      TYPE: "PAPER"
      MODRINTH_ALLOWED_VERSION_TYPE: "release"
      MODRINTH_PROJECTS: "coreprotect"

Nothing is showing up about Modrinth in the container logs

theo546 avatar Jan 02 '23 17:01 theo546

This image build will include the new Modrinth support

itzg avatar Jan 02 '23 19:01 itzg

Thank you, this is now working as expected! I did a one-time sponsor payment of 10$, thank you again for your clean and fast work!

theo546 avatar Jan 02 '23 20:01 theo546

Awesome and thanks!

itzg avatar Jan 02 '23 22:01 itzg

Sorry for the zombie issue, but I don't seem to see this working...

Here's my docker-compose (ish):

    image: itzg/minecraft-server:latest
    tty: true
    environment:
      EULA: 'TRUE'
      TYPE: PAPER
      VERSION: '1.19.3'
      MEMORY: "8G"
      USE_AIKAR_FLAGS: "true"
      MODRINTH_PROJECTS: "appleskin,easiervillagertrading,fallingtree,roundaround-inventory-management,lambdynamiclights,lighty,inventory-sorting,quickcraft,harvest,tree-harvester,sleep-warp,bed-benefits-fabric,xaero-map-addition"
      MODRINTH_ALLOWED_VERSION_TYPE: "release"
      SPIGET_RESOURCES: 50961,68193

Spiget seems to work, and if I change the type to FABRIC it also works, but with PAPER, it seems to just skip over the modrinth project downloads? (I did a docker pull on the image, to make sure I was up to date, and deleted the container for good measure....)

terafin avatar Jan 16 '23 02:01 terafin

Nevermind, looks like my error. These are modrinth mods, not plugins :) Nothing to see here, moving along!

terafin avatar Jan 16 '23 02:01 terafin

That said, the documentation implies it works with mods, and this mod for example: https://modrinth.com/mod/light-overlay does not seem to load if I put it as the only one.

terafin avatar Jan 16 '23 02:01 terafin

Sorry for the zombie issue, but I don't seem to see this working...

Don't apologize. Just open a new issue.

itzg avatar Jan 16 '23 04:01 itzg

Doing so now :) Thanks!

terafin avatar Jan 16 '23 04:01 terafin