Hui Yu
Hui Yu
`event_time` is required by K8S API spec https://raw.githubusercontent.com/kubernetes-client/c/master/kubernetes/swagger.json. So it should not be NULL By comparison, `deprecatedLastTimestamp` is optional.
`strtok_r` is not implemented on Windows. Use conditional compilation to avoid build failures on Windows For example, in this project: ```c #ifndef _WIN32 or check_symbol_exists(secure_getenv "stdlib.h" HAVE_SECURE_GETENV) #if defined(HAVE_SECURE_GETENV) ```
Hi @haesbaert Thanks for the PR! I recommend: ```c check_symbol_exists(secure_getenv "stdlib.h" HAVE_STRTOK_R) char *p = NULL; char *last = NULL; #if defined(HAVE_STRTOK_R) p = strtok_r(dup_token_string, OIDC_ID_TOKEN_DELIM, &last); /* jwt header...
Hi @haesbaert Welcome back ! and thanks for making these changes. I have a few minor comments.
Hi @brendandburns @AbrilRBS Thanks for starting this discussion ! I think `kubernetes::kubernetes` is better. That way we can follow Conan conventions. And the CMake and vcpkg https://github.com/kubernetes-client/c/blob/master/docs/vcpkg.md for this client...
Thanks @davidsanfal ! I have seen your change. After https://github.com/conan-io/conan-center-index/pull/28042 is merged, I'll merge recipes/kubernetes/all/conanfile.py back here.