lua-gd icon indicating copy to clipboard operation
lua-gd copied to clipboard

Protect declaration of LgdImageCreateFromPng* with GD_PNG feature test macro

Open spacewander opened this issue 8 years ago • 1 comments

If GD_PNG is false, neither LgdImageCreateFromPng nor LgdImageCreateFromPngPtr would be implemented. See the implementation in https://github.com/ittner/lua-gd/blob/master/luagd.c#L417 We should avoid declaring them too.

spacewander avatar Oct 31 '17 08:10 spacewander

The corresponding patch could be applied to existing code:

diff --git a/luagd.c b/luagd.c
index 9730ff7..98bc03e 100644
--- a/luagd.c
+++ b/luagd.c
@@ -2168,8 +2168,10 @@ static const luaL_Reg LgdFunctions[] =
     { "createFromGif",          LgdImageCreateFromGif },
     { "createFromGifStr",       LgdImageCreateFromGifPtr },
 #endif
+#ifdef GD_PNG
     { "createFromPng",          LgdImageCreateFromPng },
     { "createFromPngStr",       LgdImageCreateFromPngPtr },
+#endif
     { "createFromGd",           LgdImageCreateFromGd },
     { "createFromGdStr",        LgdImageCreateFromGdPtr },
     { "createFromGd2",          LgdImageCreateFromGd2 },

spacewander avatar Oct 31 '17 08:10 spacewander