pharos icon indicating copy to clipboard operation
pharos copied to clipboard

ImageCard: New title variant

Open lizlove opened this issue 11 months ago • 3 comments

The problem You can create a Pharos Image Card in the collection variant without a title, but these cards do not pass accessibility testing as the title is required for VO users.

The solution Create a variant of Image Card similar to the Collection view that styles the title property like the existing styling of the metadata slot (font size 14, underlined).

Alternatives considered Currently I am using the title property and styling it locally to resemble the first item in the metadata slot but this is not ideal.

Additional information

lizlove avatar Mar 14 '25 18:03 lizlove

@lizlove can you clarify if we should be fixing the accessibility of the existing variant? I don't think we want to keep any inaccessible variants around!

daneah avatar Mar 14 '25 18:03 daneah

It seems that if we don't pass in a "title" the component still passes in the heading and link without any inner text, which ends up causing an empty link in the focus order. If we wanted to restyle the Title as a consumer, would this be done via CSS overwriting styles? Otherwise, we'd just pass in info with the metadata slot and forgo the title, but it'd still print out that empty link.

sirrah-tam avatar Mar 14 '25 18:03 sirrah-tam

Yes, as @sirrah-tam mentioned title is an optional property, but when we don't use it it creates an empty link in the focus order.

lizlove avatar Mar 14 '25 18:03 lizlove