pharos icon indicating copy to clipboard operation
pharos copied to clipboard

Image Card refactor to remove image link

Open sirrah-tam opened this issue 1 year ago • 2 comments

This change: (check at least one)

  • [x] Adds a new feature
  • [ ] Fixes a bug
  • [ ] Improves maintainability
  • [ ] Improves documentation
  • [ ] Is a release activity

Is this a breaking change? (check one)

  • [ ] Yes
  • [x] No

Is the: (complete all)

  • [x] Title of this pull request clear, concise, and indicative of the issue number it addresses, if any?
  • [ ] Test suite(s) passing?
  • [ ] Code coverage maximal?
  • [ ] Changeset added?
  • [ ] Component status page up to date?

What does this change address? This change addresses #509 by removing the link that wraps the image within the image card.

How does this change work? This change removed the pharos-link from wrapping the image and created a click handler on the image to navigate to item's link. Added styles to convey interactivity.

sirrah-tam avatar Feb 07 '25 21:02 sirrah-tam

⚠️ No Changeset found

Latest commit: cfbcf6b696441a8401d5d927364928608dc806dd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Feb 07 '25 21:02 changeset-bot[bot]

size-limit report 📦

Path Size
packages/pharos/lib/index.js 1.03 MB (+0.02% 🔺)

github-actions[bot] avatar Feb 07 '25 21:02 github-actions[bot]

Now tracked under #979

sirrah-tam avatar Jun 10 '25 18:06 sirrah-tam