studio-support icon indicating copy to clipboard operation
studio-support copied to clipboard

Turn off a certain filter without deleting it

Open davesteps opened this issue 4 years ago • 10 comments

If you have a number of filters set up, sometimes it is nice to be able to turn off a certain filter but at the moment you need to remove it so you lose it completely. It would be nice to be able to disable the filter without deleting it. Thanks!

davesteps avatar Jul 06 '21 20:07 davesteps

This might be less needed if we unify search and filter, i.e. if one is able to type in branch=something then erasing it and readding is way faster than clicking through the filter popup second time. Additionally we might show history and/or hints in a dropdown for the search field.

Suor avatar Jul 07 '21 02:07 Suor

I like the suggestion by Alex, at least GitHub does that, but the current way seems more visual to me. In addition, we would need a big search field in order to show at least a part of the filters in this case.

Against the initial suggestion by David, it seems pretty much a simple thing to do.

mvshmakov avatar Jul 07 '21 12:07 mvshmakov

but the current way seems more visual to me

We are not required to get rid of filters popup interface, any selections there might be duplicated into search string. Going with small steps is fine of cause, if it's easy to do then let's start with that.

Suor avatar Jul 08 '21 04:07 Suor

What do you think if we just add the eye icons to each filter in the list to show/hide them? I hope this one not require complex changes. See in the example below ↓

image

arcticbear avatar Jul 20 '21 13:07 arcticbear

The eye logic is kind of reverse here, i.e. if filter is active then we hide things. Maybe use some other icon to show that it's working/in effect/applied. Checkbox?

Suor avatar Jul 20 '21 14:07 Suor

Nice suggestion @arcticbear!

The eye logic is kind of reverse here, i.e. if filter is active then we hide things. Maybe use some other icon to show that it's working/in effect/applied. Checkbox?

I'd say a toggle works better here. We are using checkboxes for multi selecting commits, and a toggle button for things like the ViewDelta mode 🤔

jellebouwman avatar Jul 20 '21 14:07 jellebouwman

Yeah, I had been thinking about the checkboxes. And I like the idea of using toggles even more. Here are examples of how both options look like in the UI:

image

arcticbear avatar Jul 20 '21 15:07 arcticbear

Toggles look too heavy for me. Drain too much attention.

Suor avatar Jul 21 '21 09:07 Suor

Yeah, agree. It was worth trying, but the checkboxes look much clear and non-distractive.

arcticbear avatar Jul 22 '21 12:07 arcticbear

Toggles also don't contradict the idea about using the search bar and show filters GH style, right? Basically, we can combine best of two approaches - power search string and a visual interface to populate it. Btw, I wonder how it's done on GitLab?

shcheklein avatar Sep 14 '21 04:09 shcheklein