dvc icon indicating copy to clipboard operation
dvc copied to clipboard
verified publisher icon iterative

dvc push hangs silently

Open davies-w opened this issue 1 year ago • 8 comments

Bug Report

dvc pull hangs silently

Description

We make some changes, that require a push. There's only a few files involved. dvc push just hangs silently.

(ds) mac:~/repos/candidate_seniority_patch/model-interfaces$ dvc status
measurement_pipelines/generate_report/dvc.yaml:capture_main_hash:                                                                                                                                  
        always changed
measurement_pipelines/generate_OC_report/dvc.yaml:capture_main_hash:
        always changed
measurement_pipelines/OneTenRegressionTest_OC/dvc.yaml:regression_test:
        changed outs:
                modified:           measurement_pipelines/OneTenRegressionTest_OC/data/industry_to_colour.pkl
data_pipelines/LightcastJobData/dvc.yaml:query_data:
        changed outs:
                not in cache:       data_pipelines/LightcastJobData/data/focus_job_posting

With --verbose on, ^C interrupts and shows this

(ds) mac:~/repos/candidate_seniority_patch/model-interfaces$ dvc push --verbose
2024-07-15 11:49:32,243 DEBUG: v3.51.2 (pip), CPython 3.11.6 on macOS-14.5-arm64-arm-64bit
2024-07-15 11:49:32,243 DEBUG: command: /Users/winton/.pyenv/versions/ds/bin/dvc push --verbose
^C2024-07-15 11:49:34,204 ERROR: interrupted by the user              
Traceback (most recent call last):
  File "/Users/winton/.pyenv/versions/ds/lib/python3.11/site-packages/dvc/cli/__init__.py", line 211, in main
    ret = cmd.do_run()
          ^^^^^^^^^^^^
  File "/Users/winton/.pyenv/versions/ds/lib/python3.11/site-packages/dvc/cli/command.py", line 27, in do_run
    return self.run()
           ^^^^^^^^^^
  File "/Users/winton/.pyenv/versions/ds/lib/python3.11/site-packages/dvc/commands/data_sync.py", line 64, in run
    processed_files_count = self.repo.push(
                            ^^^^^^^^^^^^^^^
  File "/Users/winton/.pyenv/versions/ds/lib/python3.11/site-packages/dvc/repo/__init__.py", line 58, in wrapper
    return f(repo, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/winton/.pyenv/versions/ds/lib/python3.11/site-packages/dvc/repo/push.py", line 103, in push
    used_run_cache = self.stage_cache.push(remote) if run_cache else []
                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/winton/.pyenv/versions/ds/lib/python3.11/site-packages/dvc/stage/cache.py", line 281, in push
    return self.transfer(self.repo.cache.legacy, dest_odb)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/winton/.pyenv/versions/ds/lib/python3.11/site-packages/dvc/stage/cache.py", line 264, in transfer
    if to_fs.exists(key) and first(to_fs.find(key)):
       ^^^^^^^^^^^^^^^^^
  File "/Users/winton/.pyenv/versions/ds/lib/python3.11/site-packages/dvc_objects/fs/base.py", line 453, in exists
    return self.fs.exists(path)
           ^^^^^^^^^^^^^^^^^^^^
  File "/Users/winton/.pyenv/versions/ds/lib/python3.11/site-packages/fsspec/asyn.py", line 118, in wrapper
    return sync(self.loop, func, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/winton/.pyenv/versions/ds/lib/python3.11/site-packages/fsspec/asyn.py", line 91, in sync
    if event.wait(1):
       ^^^^^^^^^^^^^
  File "/Users/winton/.pyenv/versions/3.11.6/lib/python3.11/threading.py", line 629, in wait
    signaled = self._cond.wait(timeout)
               ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/winton/.pyenv/versions/3.11.6/lib/python3.11/threading.py", line 331, in wait
    gotit = waiter.acquire(True, timeout)
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
KeyboardInterrupt

2024-07-15 11:49:34,211 DEBUG: Analytics is enabled.
2024-07-15 11:49:34,266 DEBUG: Trying to spawn ['daemon', 'analytics', '/var/folders/nr/spbjfgvs0sj47g0rvpm_kkqh0000gp/T/tmpqtuqji0u', '-v']
2024-07-15 11:49:34,272 DEBUG: Spawned ['daemon', 'analytics', '/var/folders/nr/spbjfgvs0sj47g0rvpm_kkqh0000gp/T/tmpqtuqji0u', '-v'] with pid 59917

Reproduce

I doubt this can be reproduced except in our enviroment. The problem is it works sometimes.

Expected

I expect some clear status to be shown.

Environment information

Output of dvc doctor:

$ dvc doctor

DVC version: 3.51.2 (pip)
-------------------------
Platform: Python 3.11.6 on macOS-14.5-arm64-arm-64bit
Subprojects:
        dvc_data = 3.15.1
        dvc_objects = 5.1.0
        dvc_render = 1.0.2
        dvc_task = 0.4.0
        scmrepo = 3.3.6
Supports:
        http (aiohttp = 3.9.5, aiohttp-retry = 2.8.3),
        https (aiohttp = 3.9.5, aiohttp-retry = 2.8.3),
        s3 (s3fs = 2024.6.1, boto3 = 1.34.131)
Config:
        Global: /Users/winton/Library/Application Support/dvc
        System: /Library/Application Support/dvc
Cache types: reflink, hardlink, symlink
Cache directory: apfs on /dev/disk3s3s1
Caches: local
Remotes: s3
Workspace directory: apfs on /dev/disk3s3s1
Repo: dvc, git
Repo.site_cache_dir: /Library/Caches/dvc/repo/875740855e4fead72d9038d90f145e70

Additional Information (if any):

Happens on both an ARM Mac and a Unix x86 box. We're trying to push to S3, but nothing suggests it get there.

davies-w avatar Jul 15 '24 18:07 davies-w

[!WARNING]

Rate limit exceeded

@NandanAnantharamu has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 17 minutes and 55 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between 5ddf6e6977e9d889b62b2d2cf5ea4af234ba545e and 91e059f7343825ed19355557aa4e27b97080aaa3.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Aug 28 '24 11:08 coderabbitai[bot]

closing as its redundant

NandanAnantharamu avatar Aug 28 '24 11:08 NandanAnantharamu