datachain icon indicating copy to clipboard operation
datachain copied to clipboard

Fix 'create_result_query' ordering

Open dreadatour opened this issue 1 year ago • 1 comments

Tiny fix for unused code found while working on another PR.

dreadatour avatar Oct 08 '24 15:10 dreadatour

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 87.00%. Comparing base (414872b) to head (814f933). Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
src/datachain/query/dataset.py 50.00% 1 Missing and 1 partial :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #502      +/-   ##
==========================================
- Coverage   87.01%   87.00%   -0.02%     
==========================================
  Files          92       92              
  Lines        9854     9854              
  Branches     2037     2037              
==========================================
- Hits         8574     8573       -1     
- Misses        919      920       +1     
  Partials      361      361              
Flag Coverage Δ
datachain 86.93% <50.00%> (-0.02%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 08 '24 16:10 codecov[bot]

Closing this issue because we decided to do not preserve ordering within dataset.

dreadatour avatar Oct 15 '24 10:10 dreadatour