publiccode-editor icon indicating copy to clipboard operation
publiccode-editor copied to clipboard

RFC: Use the Airbnb Style Guide with eslint.

Open bfabio opened this issue 6 years ago • 5 comments

This is a proposal to use the Airbnb Style Guide. IMHO it's the one making most sense, it's well maintained and documented, provides rules for React and it's very comprehensive.

Of course I'll provide the patches required to make the existing codebase conform to the style.

bfabio avatar Nov 17 '19 14:11 bfabio

Hi @bfabio and thanks for your contribution. From a general perspective, I agree with you, I like the ABnB style way more than the one used in this project. However, this change will require a set of changes and review which are not a priority at the moment so I'm afraid we have to reschedule a review of this (and the future commits) on a future milestone.

libremente avatar Nov 18 '19 13:11 libremente

@libremente That makes sense, I'll keep the patches on hold. Thanks.

bfabio avatar Nov 18 '19 13:11 bfabio

@tensor5 wdyt? I'd try and merge this

bfabio avatar Jun 28 '23 11:06 bfabio

I don't have a preference on one lining configuration over the another. Just two questions:

  1. I read here that airbnb assumes Babel. Does it work without?
  2. Does it integrates with TypeScript? I found this package from a quick search.

tensor5 avatar Jun 28 '23 12:06 tensor5

@tensor5 good points, I'll look into them.

bfabio avatar Jun 28 '23 12:06 bfabio