isso-comments
js: isso.js: Disable Postbox submit button on click, enable after response
Checklist
- [x] All new and existing tests are passing
- [x] I have added an entry to CHANGES.rst because this is a user-facing change or an important bugfix
- [x] I have written proper commit message(s)
What changes does this Pull Request introduce?
Disable the submit button in Postbox to prevent double posting upon click. Enable the button after receiving a response from the API endpoint.
Why is this necessary?
Fixes https://github.com/posativ/isso/issues/913
Also, you have 3 identically named commits with the same commit body. You probably meant to amend a single commit or split the tests but forgot to write commit messages.
Is there something missing that prevents you from removing the draft status?
I've noticed that E2E tests are failing due to timeout on checks, and it's happening in different places. I thought it was due to changes in PR and was looking for a solution. So for now, I'm marking PR as a draft to look for a solution.
I've noticed that E2E tests are failing due to timeout on checks, and it's happening in different places. I thought it was due to changes in PR and was looking for a solution. So for now, I'm marking PR as a draft to look for a solution.
Sorry about that, I'm still trying to understand why the integration tests are so flaky. Maybe it has something to do with using docker compose from inside the GH Actions environment, which is already container-based? The first faux-user initiated POST/PUT requests seem to work, but then there's an issue with a PUT request sometimes not actually going through.
I hope the usability of the screenshot tests wasn't too bad for you. I found them useful at the time when I created them because we were messing up some of the CSS/layout with a lot of attempted cleanups.
At least the tests don't seem to be flaky any more ;)
I hope the usability of the screenshot tests wasn't too bad for you. I found them useful at the time when I created them because we were messing up some of the CSS/layout with a lot of attempted cleanups.
At least the tests don't seem to be flaky any more ;)
It took me a little while to get the hang of them, but I found them very helpful. Thank you for creating them. They're definitely useful for moving forward!