ZoeDepth icon indicating copy to clipboard operation
ZoeDepth copied to clipboard

eval_mask utilized before declaration

Open MACILLAS opened this issue 2 years ago • 0 comments

Hi authors! Thank you so much for your work!

I'm trying to finetune your model on my own datasets, and I don't wish to use eigen_crop or garg_crop... My dataset is 'adjacent' to KITTI so I'm just changing the KITTI configs in config.py. But I get eval_mask called before declaration.

Looking through ZoeDepth/zoedepth/utils/misc.py in compute_metrics...

I wonder if the authors would consider adding an else clause to the if garg_crop or eigen_crop: at line 226?

if garg_crop or eigen_crop: 

""" CODE """

else:
    eval_mask = np.ones(valid_mask.shape)

MACILLAS avatar Jul 27 '23 14:07 MACILLAS