fancyimpute icon indicating copy to clipboard operation
fancyimpute copied to clipboard

Checking if there is any missing value to prevent the algorithm from running

Open YagmurGULEC opened this issue 2 years ago • 1 comments

Thanks for this implementation. It is really helpful. I'd like to contribute to prevent the solver from unnecessary running for complete data. I found a way to check if the data has any Nan values in the solver method of the base class. Thanks for the consideration.

YagmurGULEC avatar Oct 25 '23 17:10 YagmurGULEC

Thank you for your contribution. We aren't really updating the package. Since this isn't a bug, I am sorry to say we won't be prioritizing this PR. I'll leave it open - if we have to merge a bugfix some day, I'll merge this too so the pip update has both.

sergeyf avatar Oct 25 '23 17:10 sergeyf