s1-reader icon indicating copy to clipboard operation
s1-reader copied to clipboard

WIP noise annotation refactor

Open LiangJYu opened this issue 3 years ago • 1 comments

This PR builds on @seongsujeong's work from #62. In the early draft stage, f019bae below is the only relevant commit. I'm unsure if changes here should be a PR submitted to #62 or standalone PR pending #62 merging; currently a standalone for higher visibility.

This PR:

  • moves noise loading into an independent module.
  • only loads azimuth attributes as needed.
  • creates utils.py in src/s1reader/utils for common variables/methods. (utils. py may not be the best name?)

To do:

  • [ ] test code
  • [ ] add unit test

LiangJYu avatar Sep 21 '22 19:09 LiangJYu

@LiangJYu it is unclear to me why we need this refactor. If I am not wrong, @seongsujeong PR has not merged yet. Can we just be done with those changes in his open PR? I think I am missing or I have lost track of something.

vbrancat avatar Oct 04 '22 22:10 vbrancat