doc_widget icon indicating copy to clipboard operation
doc_widget copied to clipboard

TextPrevew.dart size is ignored

Open matthewrice345 opened this issue 3 years ago • 3 comments

Describe the bug Load up some documentation that uses the TextPreview not that the size property is ignored in the Text widget.

To Reproduce Steps to reproduce the behavior:

  1. Open up some app using the documentation
  2. View the title with 'TextPreview`
  3. note the size is ignored when set

Expected behavior The custom size used in TextPreview is rendered

matthewrice345 avatar Nov 01 '22 22:11 matthewrice345

Can you share a screenshot? I don't know if understand your problem. 🤔

isacjunior avatar Nov 02 '22 20:11 isacjunior

It's this file: https://github.com/isacjunior/doc_widget/blob/master/packages/doc_widget/lib/src/widgets/title.dart

It's not a big deal but the double size property is useless because it's not applied to the Text widget inside the TextPreview.

final preview = TextPreview( text: 'Yolo', size: 12, );

Not sure a screenshot will help much beyond showing that regardless of the size: 12, it's using the style: TextDS.heading3, without copying the size into it.

It's also not a part of the doc_widet export file so likely no one else will ever know :) so happy to close if it's not something you care to fix. No big deal

matthewrice345 avatar Nov 02 '22 21:11 matthewrice345

Recently I changed the doc_widget design and probably I forget to remove it. Feel free to open a PR removing the size.

isacjunior avatar Nov 07 '22 12:11 isacjunior