iree-org
When --iree-llvmcpu-sanitize=address is enabled, we should auto set --iree-llvmcpu-link-embedded=false
The test suite futzes with this at the CMake level but that still leaves the footgun in the compiler. Specifying the first flag causes an opaque link error about missing ASAN symbols with no clue as to how to fix it.
Recommend just making this work correctly when --iree-llvmcpu-sanitize=address is specified. Then also remove the checks and manual massaging done at the CMake level for the test suite to manage the --iree-llvmcpu-link-embedded flag.
hello，Could you give me a chance to solve this issue? Although I have limited experience in IREE, I am really interested in IREE and MLIR. @stellaraccident
Go for it. Post a PR?
Wow！Thanks for you！I'll try to reproduce this problem first, thank you very much for giving me this opportunity!
Sorry, I clicked the wrong option. Could you please assign this task to me again? @stellaraccident
Just let us know if you end up dropping it or not being able to do it and we'll reassign. Have fun!
Just let us know if you end up dropping it or not being able to do it and we'll reassign. Have fun!
Okay, I will try my best to do it.
hello, @stellaraccident : I have built this project using the following CMake commands:
# in iree file
cmake -G Ninja -B ../iree-build/ -S . \
-DCMAKE_BUILD_TYPE=RelWithDebInfo \
-DIREE_ENABLE_ASSERTIONS=ON \
-DIREE_ENABLE_SPLIT_DWARF=ON \
-DCMAKE_C_COMPILER=clang \
-DCMAKE_CXX_COMPILER=clang++ \
-DIREE_ENABLE_LLD=ON \
-DIREE_ENABLE_ASAN=ON
# in iree-build file
cmake --build .
Could you tell me how to reproduce this issue or how to trigger a link error about missing ASAN problem? Could you please give me some advice? My platform is mac-os. Thanks to you!
This commit fixes the issue. Please review: https://github.com/TSWorld1314/iree/commit/be05fdbbbfa87125b43e0bad942589958bf5b04a I submitted the code too late, I'm very sorry and thank you very much for giving me a chance as a student
hello， @stellaraccident ，this is my Pull Request，I submitted the code too late, I'm very sorry and thank you very much for giving me a chance as a student，https://github.com/openxla/iree/pull/15934
@ScottTodd I think this ticket can be closed, because of the improvements that were made in: https://github.com/openxla/iree/pull/16452
@ScottTodd I think this ticket can be closed, because of the improvements that were made in: #16452
Sort of - I only changed the CMake configuration. The compiler code could still be changed (linking the flags together or giving a clear error message when one is set but not the other).
