Some code is deprecated and some marked for removal and assert is in incorrect order

[tdltdl]

Some examples are

• MapRequest uses deprecated create signature (MediaType, String)
• new Integer(0), ...

Also propose to upgrade to latest versions All assert parameters are in the wrong order : The signature is assertEquals( expected, actual) and all test cases are like this assertEquals(asnResp.getDomain(), "af.mil") (expected is the function call and actual is the expected result...

[tdltdl]

Will also include updated values to the test cases as per #54. and update some dependencies like okhttp that was reported as vulnerable

[max-ipinfo]

Hi @tdltdl ! Thanks for your 3 PRs.

We will go over them as soon as we have a chance.

[tdltdl]

Hi @max-ipinfo I hope you are fine. Do you have an ETA for checking those fixes and merging them? Thanks!

[max-ipinfo]

@tdltdl sorry for the wait.

My hope is to take some time tomorrow, February 21 2025, to look at your PRs.

I'll keep you posted!

[max-ipinfo]

@tdltdl starting the review of the 3 PRs now. I'll keep you posted there directly.

[max-ipinfo]

@tdltdl let's focus on PR #55 for now.

Sent you a first review: https://github.com/ipinfo/java/pull/55#pullrequestreview-2634504332

[tdltdl]

Unit test fixes are here... So doing them in the wrong order forces us to do the same test fixes multiple times

[max-ipinfo]

Unit test fixes are here... So doing them in the wrong order forces us to do the same test fixes multiple times

Sorry @tdltdl, I didn't understand your comment

I fixed unit tests (including their order) in https://github.com/ipinfo/java/commit/8202b743330d75df3cbc5b5e6c6a080a43ca338f

Are you having issues rebasing your PR?