ipld-explorer-components icon indicating copy to clipboard operation
ipld-explorer-components copied to clipboard

CID search fix: empty searches are blocked

Open ravishxt opened this issue 1 year ago • 1 comments

Now empty searches can not be executed now.

Approach:

  • Implemented a if check on the input string
  • which updates the state of the search bar component for rendering the error message.
  • Additionally changed the outline and placeholder if there is any empty search.

ravishxt avatar May 18 '24 11:05 ravishxt

Thank you for submitting this PR! A maintainer will be here shortly to review it. We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the rest) and in its best form. Follow the code contribution guidelines if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment. Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on any missing things and potentially assigning a reviewer for high priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution. We are very grateful for your contribution!

welcome[bot] avatar May 18 '24 11:05 welcome[bot]

looks good to me @SgtPooki you can proceed further

Will try to meet project's coding style in future.

ravishxt avatar May 21 '24 11:05 ravishxt