ipfs-webui icon indicating copy to clipboard operation
ipfs-webui copied to clipboard

fix the file not found page

Open ChayanDass opened this issue 3 months ago • 1 comments

fixes #2453

Bug

FileNotFound was not displayed because of an early path check:

if (files.path && filesPathInfo.path && files.path !== filesPathInfo.path) {
  return null
}

When files.type === 'not-found', the paths differ, causing an early return.

##Fix

Render FileNotFound before checking for stale paths. This ensures missing files show the correct component.

image

ChayanDass avatar Oct 23 '25 16:10 ChayanDass

Thank you for submitting this PR! A maintainer will be here shortly to review it. We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the rest) and in its best form. Follow the code contribution guidelines if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment. Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on any missing things and potentially assigning a reviewer for high priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution. We are very grateful for your contribution!

welcome[bot] avatar Oct 23 '25 16:10 welcome[bot]