go-log icon indicating copy to clipboard operation
go-log copied to clipboard

Non-blocking logging

Open Stebalien opened this issue 5 years ago • 1 comments

The default zap file backend logging backend is really dumb and doesn't have any internal buffering. We need to:

  1. Buffer writes.
  2. Drop log messages when the buffer is full instead of blocking.

We should never block execution on logging.

Stebalien avatar Mar 31 '20 23:03 Stebalien

Turns out zap support sampling and we've disabled it. We should enable and tune it.

Stebalien avatar Apr 03 '20 16:04 Stebalien