distributions icon indicating copy to clipboard operation
distributions copied to clipboard

Fix: use actual repo/package/version to do go mod init

Open hsanjuan opened this issue 2 years ago • 1 comments

The build process:

  • Sets a custom GOPATH
  • Clones the repo we want to build inside it
  • Does a go mod init and requires the repository we want to build directly (ignoring submodules) by doing a "rev-parse HEAD" on what we cloned
  • Then go-builds the package "go build [...] -mod=mod my.package/abc.

I'm not sure why -mod=mod is updated, but this automatically updates the go.mod when working with submodules (sub-packages) that are tagged separately, to the point that it uses wrong releases (not the checked out one).

This has not been noticed in 4 years because we usually build the last tagged version of things. It you attempt to build a submodule with their own tag while using a tag that is not the latest it will start misbehaving.

This attempts to require exactly what we are trying to build in the go.mod file.

hsanjuan avatar Jun 13 '23 21:06 hsanjuan

This change produced no new differences in built artifacts.

github-actions[bot] avatar Jun 13 '23 21:06 github-actions[bot]