distributions icon indicating copy to clipboard operation
distributions copied to clipboard

Support plugin builds

Open hsanjuan opened this issue 2 years ago • 1 comments

Placing a "plugin" file in the dists/<repo> folder will trigger a -buildmode=plugin build using CGO.

hsanjuan avatar Jun 13 '23 13:06 hsanjuan

I assume you've been testing with #857, has that been working alright?

Don't see anything outstanding outside of the two comments below so LGTM, although I haven't done any local testing so if anyone else wants to give some eyes (especially ones that barely know bash sweat_smile) that could be useful.

It "works"... but I don't find it very clean, the approach is a bit arbitrary.

Moreover the CI is not prepared to build on anything non linux/amd64, because gcc cross-compiling tools are not installed, and I look to at least have darwin and apparently it is not as easy as installing a gcc package.

So I'm not sure it is worth merging. I thought building the plugin in the exact conditions that Kubo is built would ensure compatibility, but also apparently the plugin just works fine now by building directly by hand (I have no idea if it has to do with Boxo, with re-organizing code, with tagged releases of things or what exactly...).

hsanjuan avatar Jun 14 '23 18:06 hsanjuan