boxo icon indicating copy to clipboard operation
boxo copied to clipboard

Make GOOS=js GOARCH=wasm a possible build target

Open bahner opened this issue 2 years ago • 5 comments

As writing files is not really applicable in WebAssembly create a noop filewriter to make compilation possible.

bahner avatar Jan 28 '24 09:01 bahner

Thank you for submitting this PR! A maintainer will be here shortly to review it. We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the rest) and in its best form. Follow the code contribution guidelines if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment. Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on any missing things and potentially assigning a reviewer for high priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution. We are very grateful for your contribution!

welcome[bot] avatar Jan 28 '24 09:01 welcome[bot]

Incidentally, I believe this closes issue #186

bahner avatar Jan 28 '24 11:01 bahner

@Jorropo when you take a look at this, then feel free to suggest actual writing to in-memory files. I just don't see any reason, but if there is then just holler.

bahner avatar Feb 04 '24 20:02 bahner

I would like to support WASM too but I want to you know that you havn't added anything to the test suite. If we don't test WASM in CI I could merge it but with expectations that it's not maintained, experimental and could break at any moment.

Jorropo avatar Feb 05 '24 00:02 Jorropo

Hepp! Good feedback. A little busy here, but I'll follow up.

bahner avatar Feb 13 '24 01:02 bahner