boxo icon indicating copy to clipboard operation
boxo copied to clipboard

feat: blockstore: GetMany blockstore method

Open i-norden opened this issue 2 years ago • 2 comments

This PR introduces a GetMany blockstore method to compliment the existing PutMany method. This is for use in a GetMany go-ipld-cbor datastore implementation which, in turn, is for use in parallel ForEach methods for both go-amt-ipld and go-hamt-ipld. This PR uses the TxnDatastore keytransform/namespace wrapper introduced in https://github.com/ipfs/go-datastore/pull/210.

GetMany go-ipld-cbor PR that uses this: https://github.com/ipfs/go-ipld-cbor/pull/97

TODO: Replace replace directives if/when the dependency is merged and released

i-norden avatar Oct 17 '23 22:10 i-norden

Thank you for submitting this PR! A maintainer will be here shortly to review it. We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the rest) and in its best form. Follow the code contribution guidelines if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment. Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on any missing things and potentially assigning a reviewer for high priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution. We are very grateful for your contribution!

welcome[bot] avatar Oct 17 '23 22:10 welcome[bot]

Codecov Report

Attention: Patch coverage is 50.00000% with 42 lines in your changes are missing coverage. Please review.

Project coverage is 65.64%. Comparing base (0a566c9) to head (b3ed048). Report is 124 commits behind head on main.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #492      +/-   ##
==========================================
- Coverage   65.78%   65.64%   -0.15%     
==========================================
  Files         207      203       -4     
  Lines       25156    25385     +229     
==========================================
+ Hits        16549    16663     +114     
- Misses       7147     7235      +88     
- Partials     1460     1487      +27     
Files Coverage Δ
blockstore/blockstore.go 54.95% <50.00%> (-3.02%) :arrow_down:

... and 42 files with indirect coverage changes

codecov[bot] avatar Oct 23 '23 14:10 codecov[bot]