boxo icon indicating copy to clipboard operation
boxo copied to clipboard

feat(routing/dht/zikade): add dht routing implementation using zikade

Open iand opened this issue 2 years ago • 5 comments

Add support for the Zikade Amino DHT implementation as a routing choice.

iand avatar Sep 26 '23 14:09 iand

routing/dht does not exists btw, no need to add v2

Understood. I chose this on the assumption that dht v1 would still be needed for a while and might end up in Boxo. Happy to remove the v2 if needed

iand avatar Sep 26 '23 15:09 iand

@iand : just in case this was an accident, the team teans to not look at draft PRs. Please callout if you're wanting feedback on the current state (or move out of draft).

BigLep avatar Oct 02 '23 23:10 BigLep

@BigLep it's not an accident, I wanted early visibility while I am working on it. Will mark it ready for review when complete.

iand avatar Oct 02 '23 23:10 iand

Codecov Report

Merging #472 (77fabf8) into main (ba5ba1a) will decrease coverage by 0.06%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #472      +/-   ##
==========================================
- Coverage   65.57%   65.51%   -0.06%     
==========================================
  Files         207      207              
  Lines       25543    25543              
==========================================
- Hits        16749    16735      -14     
- Misses       7323     7335      +12     
- Partials     1471     1473       +2     

see 11 files with indirect coverage changes

codecov[bot] avatar Oct 03 '23 10:10 codecov[bot]

@Jorropo would you be able to take another look?

iand avatar Nov 01 '23 15:11 iand