ipfs-css icon indicating copy to clipboard operation
ipfs-css copied to clipboard

Redefining `.link` changes the specificity and causes suprises

Open olizilla opened this issue 4 years ago • 1 comments

Colours of things in ipld explorer have been overriden where ever they are also a .link. It's an unfortunate inclusion in tachyons, but we've used it to strip underlines off things in a few places. When it got overridden in ipfs-css it's specificity got a boost and it now overrides colours in a few places

ipld explorer cid info panel... the 12 in the legend should be orange to match the 12 in the multihash Screenshot 2021-04-23 at 14 42 59

ipld explorer graph crumb... the text colour should match the underline colour Screenshot 2021-04-23 at 15 12 26

I suggest we remove .link from ipfs-css

olizilla avatar Apr 23 '21 14:04 olizilla

Sounds sensible, but this will be a breaking change requiring major release + additional work to inspect every screen in webui and other places ipfs-css is used 😬

lidel avatar Apr 23 '21 17:04 lidel