ipdk icon indicating copy to clipboard operation
ipdk copied to clipboard
verified publisher icon ipdk-io

p4sde not be compiled

Open qzhan16 opened this issue 3 years ago • 2 comments

reproduce this at commit 45e163a5413e7da6

Seems the script build_p4sde.sh needs minor change as below, otherwise, p4sde will not be built.

diff --git a/build/networking/scripts/build_p4sde.sh b/build/networking/scripts/build_p4sde.sh index 5b5f875..90e7a69 100755 --- a/build/networking/scripts/build_p4sde.sh +++ b/build/networking/scripts/build_p4sde.sh @@ -63,7 +63,7 @@ cd p4-driver git checkout 780b3dfa205815e87f4580383cc37bfa30187f7c

pip3 install distro -cd p4-driver/tools/setup +cd tools/setup if [ "${OS}" = "Ubuntu" ]; then echo 'debconf debconf/frontend select Noninteractive' | debconf-set-selections fi

qzhan16 avatar Jun 20 '22 05:06 qzhan16

Hi @qzhan16, thanks for reporting this issue. Can you file a PR, following the contributing guidelines? Also, instead of using cd above, it would be better to use appropriate pushd and popd rather than assuming you are in a specific directory.

mestery avatar Jun 27 '22 15:06 mestery

Hi @mestery , the pull request has been created https://github.com/ipdk-io/ipdk/pull/176

qzhan16 avatar Jun 28 '22 00:06 qzhan16

Closing the issue as it is already addressed by @qzhan16 with PR #176

vsureshkumarp avatar Sep 28 '22 11:09 vsureshkumarp