ipdk-io
Storage recipe lacks CI integration
@mestery - please add Piotr Wludzik (GH id: pjwludzi) to the project and assign to this issue - he already supports CI integration. I am not able to select him as an assignee.
@intelfisz Did you guys merge something for this without referencing this issue?
Also, I see you did merge some CI for storage, but you do not have an equivalent -skip job, which means the storage CI will run even when people are modifying code outside of storage. Please address this too with this issue here.
Aravind configured GH actions to run storage unit tests. However, there are some virtualization related issues with integration tests - I will add you to the thread. @mgaravin - can you please modify GH actions to include the -skip job? Also, please sync with @mestery in terms of our proceeding with integration tests.
@mestery: I have included "path filter" to run storage CI, paths: - 'build/storage/**' Do you see any issues with this approach?
@mgaravin Yes. The problem is that we want to require the storage job. However, when we do this, your path filter will cause it to not run when people modify code outside of your filter. And thus, we won't be able to merge the PRs there.
The fix for this is to have a skip job. Look at how we do this in OPI here. You can see the -skip.yml files have the same job names, but just echo something as output. And they have the reverse path filters as well.
Let me know if this makes sense. We can't make the storage required until this is fixed.
@mestery : Yes, your suggestion makes sense, i will raise a PR with changes! Thanks for the hint!