python-epo-ops-client icon indicating copy to clipboard operation
python-epo-ops-client copied to clipboard

Added docstring and type annotations to family(), removed parameter endpoint

Open mattkeanny opened this issue 2 years ago • 3 comments

Starting with type annotations. Acc. to ops specs, endpoint is not used in family service. Not used in tests either. Options: either document it in docstring or remove it. Went for second option. The type annotations are acc. to python 3.6 (although commit comment says py3.8).

mattkeanny avatar Jan 28 '24 19:01 mattkeanny

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 77.54%. Comparing base (d7e696a) to head (6baeba6). Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
epo_ops/api.py 80.00% 2 Missing :warning:
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #87       +/-   ##
===========================================
- Coverage   99.76%   77.54%   -22.23%     
===========================================
  Files          18       18               
  Lines         428      432        +4     
===========================================
- Hits          427      335       -92     
- Misses          1       97       +96     
Flag Coverage Δ
unittests 77.54% <80.00%> (-22.23%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 28 '24 19:01 codecov[bot]

Would it help if I check out this branch and use it in my tests?

CholoTook avatar Mar 21 '24 23:03 CholoTook

Would it help if I check out this branch and use it in my tests?

@CholoTook would be great, yes.

mattkeanny avatar Apr 02 '24 15:04 mattkeanny