python-epo-ops-client icon indicating copy to clipboard operation
python-epo-ops-client copied to clipboard

Throw an error if `original` is used with any incompatible method

Open gsong opened this issue 2 years ago • 1 comments

Pitch

@amotl: Skimming through the ops guide, section 4.5 reads:

As OPS provides access to data that is held inside the EPO, the OPS services (except the number-service) require the input to be in one of the two EPO formats: epodoc or docdb. The most common use case of the number-service is thus to transform numbers that are given in domestic formats of different countries to the EPO formats that can then be used for receiving published, family, register, legal or classification data.

This would tend to reinforce your suggestion to raise an early exception when using original in any method except the number() method. See also https://github.com/ip-tools/python-epo-ops-client/pull/81#issuecomment-1913278136 for more info.

@gsong says:

We need to flesh out design details for this.

gsong avatar Jan 27 '24 18:01 gsong

In favour. I guess that would qualify as "breaking change" though?

mattkeanny avatar Jan 31 '24 10:01 mattkeanny