firefly icon indicating copy to clipboard operation
firefly copied to clipboard

enhancement: enables screen capturing for all views except the mnemonics

Open paul-boegelsack opened this issue 3 years ago • 2 comments

Summary

This PR disables the screen capturing just for views which display a recovery phrase or a seed.

Changelog

- Adds privacy enbale/disable function to capacitorAPI
- Enables the privacy for RecoveryPhrase, VerifyRecoveryPhrase and TextImport (onboarding)

Relevant Issues

Closes #4491

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • [ ] MacOS
    • [ ] Linux
    • [ ] Windows
  • Mobile
    • [x] iOS
    • [x] Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick all of the following boxes that are relevant to your changes.

  • [x] I have followed the contribution guidelines for this project
  • [x] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have added or modified tests that prove my changes work as intended
  • [ ] I have verified that new and existing unit tests pass locally with my changes
  • [ ] I have verified that my latest changes pass CI workflows for testing and linting
  • [ ] I have made corresponding changes to the documentation

paul-boegelsack avatar Sep 15 '22 08:09 paul-boegelsack

@amadeu2 On my devices I'm able to do screenshots with iOS no matter if the privacy is enabled or not. Could you confirm that? I'm a bit confused about the plugin description regarding iOS: https://github.com/capacitor-community/privacy-screen

paul-boegelsack avatar Sep 15 '22 08:09 paul-boegelsack

@amadeu2 On my devices I'm able to do screenshots with iOS no matter if the privacy is enabled or not. Could you confirm that? I'm a bit confused about the plugin description regarding iOS: https://github.com/capacitor-community/privacy-screen

Yes on iOS the plugin isn't working as we need, we could use userDidTakeScreenshotNotification and show the grey screen https://developer.apple.com/documentation/uikit/uiapplication/1622966-userdidtakescreenshotnotificatio

amadeu2 avatar Sep 22 '22 04:09 amadeu2