fix: splash screen delays

[paul-boegelsack]

Summary

This PR removes the empty view that appears for some seconds when the splash screen hides.

Changelog

- Changes the conditions that check if the splash screen should be hidden

Relevant Issues

Closes #4532

Testing

Platforms

Please select any platforms where your changes have been tested.

• Desktop
  • [ ] MacOS
  • [ ] Linux
  • [ ] Windows
• Mobile
  • [x] iOS
  • [x] Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick all of the following boxes that are relevant to your changes.

• [x] I have followed the contribution guidelines for this project
• [x] I have performed a self-review of my own code
• [ ] I have commented my code, particularly in hard-to-understand areas
• [ ] I have added or modified tests that prove my changes work as intended
• [ ] I have verified that new and existing unit tests pass locally with my changes
• [ ] I have verified that my latest changes pass CI workflows for testing and linting
• [ ] I have made corresponding changes to the documentation

[paul-boegelsack]

There is an improvement indeed, tested on android and works great. Added a coment though because changing the language is not updating correctly 🙏🏼

Thanks for catching this, I re added the isLocaleLoaded condition 🙏

[begonaalvarezd]

To test it well we need to build a production release and open / close the app from the device to mesure the init times. On Android, we still need to wait the 3 seconds only for onboarding routes to avoid language jumps even on high end devices as Pixel 3, we should remove de timeout only for the login route. On iOS on my iPhone 7 there are no performance issues even at onboarding, so we could apply the delay only for Android.

I tested installing an alpha on my phone, closing and opening the app i installed, woudlnt that be enough to test?

[paul-boegelsack]

To test it well we need to build a production release and open / close the app from the device to mesure the init times. On Android, we still need to wait the 3 seconds only for onboarding routes to avoid language jumps even on high end devices as Pixel 3, we should remove de timeout only for the login route. On iOS on my iPhone 7 there are no performance issues even at onboarding, so we could apply the delay only for Android.

We should definitely take this into account when setting up mobile for Shimmer. For now I would just fix the blank view after the splash screen. Does the blank screen still appear on your devices?