firefly icon indicating copy to clipboard operation
firefly copied to clipboard

feat: alias activity

Open MarkNerdi996 opened this issue 3 years ago • 1 comments

Summary

Introduces the concept of Alias outputs to the activity log. If an alias output is created when minting a token, the corresponding transaction gets split into 2 activities (Minting and Alias)

Changelog

- add activity tile for aliases
- update transaction details for aliases
- update filter logic for aliases

Relevant Issues

Closes #4254

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • [ ] MacOS
    • [ ] Linux
    • [ ] Windows
  • Mobile
    • [ ] iOS
    • [ ] Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick all of the following boxes that are relevant to your changes.

  • [ ] I have followed the contribution guidelines for this project
  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have added or modified tests that prove my changes work as intended
  • [ ] I have verified that new and existing unit tests pass locally with my changes
  • [ ] I have verified that my latest changes pass CI workflows for testing and linting
  • [ ] I have made corresponding changes to the documentation

MarkNerdi996 avatar Sep 14 '22 12:09 MarkNerdi996

I think we need some input from ux about what to display on the activity popup, and the tile. Also we are not displaying the correct storage deposit for the foundry output activity, it is showing as 0. p.s. you have failing tests.

nicole-obrien avatar Sep 19 '22 21:09 nicole-obrien