firefly icon indicating copy to clipboard operation
firefly copied to clipboard

feat: skip migration bundle mining in mobile

Open begonaalvarezd opened this issue 3 years ago • 0 comments

Summary

Please summarize your changes, describing what they are and why they were made.

Adapt migration bundle mining warning for mobile: if firefly detects funds on one or more spent addresses, we recommend the user to use the desktop app to proceed with the migration, but we allow then to proceed and skip bundle mining

Also, there was a race condition in mobile when calling processMigratedTransactions account was undefined, leading to errors updating migratedTransactions.

Changelog

- feat: adapt bundle mining warning for mobile
- fix: migratedTransactions race condition unpopulated accounts

Relevant Issues

Please list any related issues using development keywords.

Close #3804

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • [ ] MacOS
    • [ ] Linux
    • [ ] Windows
  • Mobile
    • [ ] iOS
    • [x] Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick all of the following boxes that are relevant to your changes.

  • [x] I have followed the contribution guidelines for this project
  • [x] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have added or modified tests that prove my changes work as intended
  • [ ] I have verified that new and existing unit tests pass locally with my changes
  • [ ] I have verified that my latest changes pass CI workflows for testing and linting
  • [ ] I have made corresponding changes to the documentation

begonaalvarezd avatar Aug 01 '22 08:08 begonaalvarezd