crypto.rs icon indicating copy to clipboard operation
crypto.rs copied to clipboard

Derive some traits for ed25519::{PublicKey, Signature}

Open thibault-martinez opened this issue 4 years ago • 3 comments

Description of change

Derive some common traits for public types. Without the traits, these types are basically unusable by bee.

Change checklist

Add an x to the boxes that are relevant to your changes, and delete any items that are not.

  • [x] I have followed the contribution guidelines for this project
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I have made corresponding changes to the documentation
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes

thibault-martinez avatar Jul 08 '21 11:07 thibault-martinez

What's the status of this PR? IOTA-Streams would be interested in it getting merged 🙂

arnauorriols avatar Feb 04 '22 10:02 arnauorriols

Last time I checked, some trait impls were missing in the dependencies and the owners didn't reply, I'll try to check again

thibault-martinez avatar Feb 04 '22 10:02 thibault-martinez

We could separate the serde traits in a different PR, and get the basic ones merged.

arnauorriols avatar Feb 07 '22 12:02 arnauorriols