trapeze icon indicating copy to clipboard operation
trapeze copied to clipboard

fix #96: Env var JSON parsing error

Open leo-jnesis opened this issue 3 years ago • 2 comments

The goal of this PR is to fix #96

  • create a configuration file with a non-defaulted var SOME_VERSION, used as versionName from android for example
  • run SOME_VERSION="1.2.3" npx trapeze
  • [ ] no error should pop in the console, and you should not be prompted for a value for SOME_VERSION
  • [ ] everything should work as before when using JSON formatted vars also

leo-jnesis avatar Aug 10 '22 07:08 leo-jnesis

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
trapeze ✅ Ready (Inspect) Visit Preview Aug 30, 2022 at 1:00PM (UTC)

vercel[bot] avatar Aug 10 '22 07:08 vercel[bot]

Nice, want to make one small change to the logging but will get this merged shortly. Thanks for the PR!

mlynch avatar Aug 18 '22 18:08 mlynch

@leo-jnesis apologies for the slow response here, was on vacation. Can you change the console.log's to use the log utility from ./util/log and also just make it a single call to log() instead of two (or give me permission to push to your repo)? Then we can get this merged

mlynch avatar Aug 29 '22 21:08 mlynch

@leo-jnesis apologies for the slow response here, was on vacation. Can you change the console.log's to use the log utility from ./util/log and also just make it a single call to log() instead of two (or give me permission to push to your repo)? Then we can get this merged

I gave you permission 😄 wasn't 100% sure about the wordings also, so I think it's easier that way !

Thanks @mlynch

leo-jnesis avatar Aug 30 '22 08:08 leo-jnesis

Landed in 5.0.1. Thanks @leo-jnesis!

mlynch avatar Aug 30 '22 17:08 mlynch