stencil icon indicating copy to clipboard operation
stencil copied to clipboard

refactor(telemetry) relocating helpers into the @utils sub-module

Open splitinfinities opened this issue 4 years ago • 0 comments

Pull request checklist

Please check if your PR fulfills the following requirements:

  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • [x] Build (npm run build) was run locally and any changes were pushed
  • [x] Unit tests (npm test) were run locally and passed
  • [x] E2E Tests (npm run test.karma.prod) were run locally and passed
  • [x] Prettier (npm run prettier) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • [ ] Bugfix
  • [ ] Feature
  • [x] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] Documentation content changes
  • [ ] Other (please describe):

What is the current behavior?

GitHub Issue Number: N/A

What is the new behavior?

  • The helpers introduced in the Telemetry PR should have been usable from within the @util's submodule. Hopefully, these can be even more reused throughout the codebase.

Does this introduce a breaking change?

  • [ ] Yes
  • [x] No

Testing

Other information

splitinfinities avatar Sep 27 '21 15:09 splitinfinities