starters icon indicating copy to clipboard operation
starters copied to clipboard

feat: RxJS 7+ support on Ionic/Angular default template.

Open Sampath-Lokuge opened this issue 3 years ago • 2 comments

Prerequisites

Describe the Feature Request

Hi, I have created a new Ionic/ Angular(14) app. But still, it has "rxjs": "~6.6.0",.

Describe the Use Case

Angular 14 supports RxJS 7+ now.

Describe Preferred Solution

This new RxJS is so much better and smaller. So we would like to have it with the default template.

Describe Alternatives

No response

Related Code

No response

Additional Information

No response

Sampath-Lokuge avatar Jun 09 '22 04:06 Sampath-Lokuge

We should probably update the dependency. Would you like to contribute and put up a PR for this change? I'd be happy to review it.

The work involved should be to change this line to use version ~7.5.0: https://github.com/ionic-team/starters/blob/main/angular/base/package.json#L23

This is the same version that ships with an Angular app created with ng new.

liamdebeasi avatar Jun 09 '22 14:06 liamdebeasi

Hi,

Thanks for the opportunity. But I have never done any PR yet and I'm not in the situation to learn that and do that too due to my projects. Sorry about that. But I hope you'll do that and will close this issue soon. This is a significant change on the Ionic/Angular template due to many performances and size improvements with the latest RxJS 7+ versions. Thanks in advance!

Sampath-Lokuge avatar Jun 09 '22 15:06 Sampath-Lokuge

more than rxjs 7 need to be updated https://github.com/ionic-team/starters/issues/1732

mhamri avatar Sep 25 '22 12:09 mhamri