starters icon indicating copy to clipboard operation
starters copied to clipboard
verified publisher icon ionic-team

feat(angular) Add recommendation for Ionic VS Code extension

Open dtarnawsky opened this issue 4 years ago • 3 comments

This will cause a popup in VS Code to recommend installation of the Ionic VS Code extension.

dtarnawsky avatar Apr 11 '22 22:04 dtarnawsky

Do we want to suggest this for React and Vue as well?

mhartington avatar Jun 06 '22 13:06 mhartington

Do we want to suggest this for React and Vue as well?

If all went well with this PR I was going to do the React and Vue starters as well.

dtarnawsky avatar Jun 06 '22 14:06 dtarnawsky

This PR is now updated with React and Vue but is breaking because the main branch is broken (if you run tsc). The dependency @types/tar relies on minipass and it introduced breaking new types. Updating to the latest @types/tar and installing @types/minipass works but it also means that typescript needs to be updated to v4 which tslint-ionic-rules doesnt like as a peer dependency (it is ~3.7.2).

dtarnawsky avatar Aug 16 '22 14:08 dtarnawsky

@mhartington This PR includes Vue, React and Angular. Any reason it couldn't be merged?

dtarnawsky avatar Oct 06 '22 14:10 dtarnawsky