ionic-framework icon indicating copy to clipboard operation
ionic-framework copied to clipboard
verified publisher icon ionic-team

Added InputInputEventDetail exported types

Open filifunk opened this issue 1 year ago • 6 comments

Issue number: resolves #29518

What is the current behavior?

IonInput in React apps can't import the correct type for typescript.

What is the new behavior?

Since it is in the file exported, people using IonInput can import the correct type.

Does this introduce a breaking change?

  • [ ] Yes
  • [x ] No

Other information

Liam DeBeasi told me it was a bug a couple days ago and pointed out to where it needed to be added.

filifunk avatar May 15 '24 23:05 filifunk

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2024 11:40pm

vercel[bot] avatar May 15 '24 23:05 vercel[bot]

image

screenshot of conversation with Liam

filifunk avatar May 16 '24 12:05 filifunk

Thank you for submitting the PR!

Is there an issue opened that ties to this PR?

thetaPC avatar May 16 '24 15:05 thetaPC

I looked just now and didn't find one! Hope this works (first PR ever)

filifunk avatar May 16 '24 16:05 filifunk

Congrats on your first PR!!! 🎉

We would need an open issue to be tied to this PR so we can get as much context as possible to provide a review. You can fill out this form to submit a bug. Once you have created one, please add it to the issue number under the PR description. Thank you!

thetaPC avatar May 16 '24 16:05 thetaPC

Great, updated!

filifunk avatar May 16 '24 23:05 filifunk