capacitor icon indicating copy to clipboard operation
capacitor copied to clipboard

fix(android): Avoid handling responses in WebViewLocalServer (#4240, #5394)

Open Zacherl opened this issue 3 years ago • 2 comments

Fixes #4240 Fixes #5394

The PR should fix the Android redirect issue. More importantly, it fixes this issue without destroying the native bridge on redirects.

It actually also fixes this issue for me: https://github.com/ionic-team/capacitor/issues/5394

It is inspired by this comment: https://github.com/ionic-team/capacitor/pull/4437#issuecomment-1081300621

I do not know a lot about the codebase, so I am not sure if the workaround I proposed is suitable, but it works without issues for me; I used it for implementing single sign on with Keycloak.

Zacherl avatar Aug 17 '22 15:08 Zacherl

Having the Same Issue with keycloak. Any updates to this PR? How can one support this fix?

Michriko avatar Aug 29 '22 09:08 Michriko

Hi @jcesarmobile, as you responded to the original issue, could you tell me what the next steps would be? I would love to dig deeper in this issue if the PR is not suitable, but I'm not sure how to proceed.

Zacherl avatar Sep 08 '22 07:09 Zacherl

Hi @Zacherl Thank you for this PR !

It has fixed my redirection issue in Android. Also I confirm it seems it doesn't breaks the native bridge as my different capacitor plugins are still working well after the redirect. This was not true when using the suggested patch in https://github.com/ionic-team/capacitor/issues/4240

gkielwasser avatar Nov 17 '22 08:11 gkielwasser