angular-toolkit icon indicating copy to clipboard operation
angular-toolkit copied to clipboard

Wrong build path on Windows 10

Open julienboulay opened this issue 6 years ago • 1 comments

Summary

Build path is wrong on windows 10. It create a C folder like C:/C/path/to/project/www

Steps to reproduce

Using @ionic/[email protected] Run ìonic cordova build Android` on Windows 10

Fix

In angular-toolkit/builders/cordova-build/index.ts, line 56 Replace :

browserOptions.outputPath = join(cordovaBasePath, normalize('www'));

By :

browserOptions.outputPath = getSystemPath(join(cordovaBasePath, normalize('www')));

otherwise, outputPath get the following value : /C/path/to/project/www

julienboulay avatar Jan 30 '20 11:01 julienboulay

I can create a pull request to fix it, if needed, but I can't see any 1.x.x branch to support this PR.

Are there any plan to maintain 1.x versions ?

julienboulay avatar Jan 30 '20 12:01 julienboulay