react-native-google-mobile-ads icon indicating copy to clipboard operation
react-native-google-mobile-ads copied to clipboard

refactor: Change Java to Kotlin within ReactNativeGoogleMobileAds related files

Open l2hyunwoo opened this issue 1 year ago • 1 comments

Description

  • Since react-native@73 using Kotlin is default for android module. Even if it can't bring effect to this project, most of references, documents will only support Kotlin. The conversion to Kotlin within the Android module should be done slowly, to make it easier to maintain the module in the future.

Related issues

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • [x] Yes
  • My change supports the following platforms;
    • [x] Android
    • [ ] iOS
  • My change includes tests;
    • [ ] e2e tests added or updated in __tests__e2e__
    • [ ] jest tests added or updated in __tests__
  • [ ] I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • [ ] Yes
    • [x] No

Test Plan


Think react-native-google-mobile-ads is great? Please consider supporting the project with any of the below:

  • 👉 Star this repo on GitHub ⭐️
  • 👉 Follow Invertase on Twitter

l2hyunwoo avatar Aug 03 '24 08:08 l2hyunwoo

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Aug 03 '24 08:08 CLAassistant

Hello 👋, this PR has been opened for more than 2 months with no activity on it.

If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!

You have 15 days until this gets closed automatically

github-actions[bot] avatar Sep 01 '24 11:09 github-actions[bot]

These changes actually look great! They're much easier to review by looking at the relevant commits directly. @dylancom, since I can't see the CI test results, I assume the test workflows have yet to be approved for this PR?

DoctorJohn avatar Sep 06 '24 21:09 DoctorJohn

@mikehardy Could you have a look at this?

dylancom avatar Sep 09 '24 12:09 dylancom

:tada: This PR is included in version 14.2.4 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

mikehardy avatar Oct 07 '24 20:10 mikehardy