react-native-firebase icon indicating copy to clipboard operation
react-native-firebase copied to clipboard

feat(auth): TOTP

Open mccjul opened this issue 1 year ago • 4 comments

Description

This PR is to add TOTP feature to auth.

Related issues

#7483

Release Summary

Adds TOTP feature to auth.

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • [ x ] Yes
  • My change supports the following platforms;
    • [ x ] Android
    • [ x ] iOS
  • My change includes tests;
    • [ ] e2e tests added or updated in packages/\*\*/e2e
    • [ ] jest tests added or updated in packages/\*\*/__tests__
  • [ x ] I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • [ ] Yes
    • [ x ] No

Test Plan

Currently working on the tests but would like some feedback before I write a ton of tests if the way I wrote it won't be accepted.

Whats left

  • [ ] Write e2e test
  • [ ] Validate ios implementation is valid

mccjul avatar Mar 31 '24 21:03 mccjul

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 31, 2024 9:11pm

vercel[bot] avatar Mar 31 '24 21:03 vercel[bot]

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Mar 31 '24 21:03 CLAassistant

Hello 👋, this PR has been opened for more than 2 months with no activity on it.

If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!

You have 15 days until this gets closed automatically

github-actions[bot] avatar Apr 28 '24 21:04 github-actions[bot]