react-native-firebase icon indicating copy to clipboard operation
react-native-firebase copied to clipboard

`useEmulator()` has been renamed to `connect<PackageName>Emulator()`

Open mikehardy opened this issue 2 years ago • 13 comments

Alter auth (and perhaps other packages already converted v9 API) to new emulator APIs

It appears that the v9 APIs have moved from useEmulator to connect<PackageName>Emulator as an API convention, but I think only the database module is converted correctly at the moment


          `useEmulator()` has been renamed to `connectDatabaseEmulator()`. `getServerTime()` actually doesn't exist in the V9 API. I think that was left over from when I was copying over some functions from V8 (compat)

Originally posted by @exaby73 in https://github.com/invertase/react-native-firebase/pull/7136#discussion_r1295671691

mikehardy avatar Sep 19 '23 15:09 mikehardy

Hello 👋, to help manage issues we automatically close stale issues.

This issue has been automatically marked as stale because it has not had activity for quite some time.Has this issue been fixed, or does it still require attention?

This issue will be closed in 15 days if no further activity occurs.

Thank you for your contributions.

github-actions[bot] avatar Oct 17 '23 15:10 github-actions[bot]

Hey @mikehardy. What is the next steps for this? Let me know where I can help

exaby73 avatar Oct 18 '23 06:10 exaby73

Hey @exaby73 the next steps are to implement in the new API shape (connect<PackageName>Emulator() vs useEmulator) in the modular / v9 API space. Success criteria to close this issue are to do that and migrate our e2e test app calls to use them, while adding a deprecation note on the old useEmulator calls. I think that's it ?

mikehardy avatar Oct 18 '23 21:10 mikehardy

Could we make this an umbrella issue to track which packages have the new API and which don't? I'm thinking for the time being, we still use useEmulator under the hood while wrapping it with connect<PackageName>Emulator

exaby73 avatar Oct 19 '23 07:10 exaby73

Hello 👋, to help manage issues we automatically close stale issues.

This issue has been automatically marked as stale because it has not had activity for quite some time.Has this issue been fixed, or does it still require attention?

This issue will be closed in 15 days if no further activity occurs.

Thank you for your contributions.

github-actions[bot] avatar Nov 16 '23 07:11 github-actions[bot]

I've been unable to connect firebase storage to my emulator that's running using useEmulator. Could this be related?

cvincentcoleman avatar Dec 12 '23 14:12 cvincentcoleman

unlikely - we haven't done the work here yet, nevertheless our e2e suite uses emulator for all modules that support it (including storage) on current versions of firebase-tools and firebase-ios-sdk/firebase-android-sdk and it's working.

So, I suspect something else

mikehardy avatar Dec 12 '23 21:12 mikehardy

Hello 👋, to help manage issues we automatically close stale issues.

This issue has been automatically marked as stale because it has not had activity for quite some time.Has this issue been fixed, or does it still require attention?

This issue will be closed in 15 days if no further activity occurs.

Thank you for your contributions.

github-actions[bot] avatar Jan 09 '24 22:01 github-actions[bot]

Not stale

exaby73 avatar Jan 15 '24 06:01 exaby73

Hello 👋, to help manage issues we automatically close stale issues.

This issue has been automatically marked as stale because it has not had activity for quite some time.Has this issue been fixed, or does it still require attention?

This issue will be closed in 15 days if no further activity occurs.

Thank you for your contributions.

github-actions[bot] avatar Feb 12 '24 07:02 github-actions[bot]

Hello 👋, to help manage issues we automatically close stale issues.

This issue has been automatically marked as stale because it has not had activity for quite some time.Has this issue been fixed, or does it still require attention?

This issue will be closed in 15 days if no further activity occurs.

Thank you for your contributions.

github-actions[bot] avatar Mar 29 '24 04:03 github-actions[bot]

Hello 👋, to help manage issues we automatically close stale issues.

This issue has been automatically marked as stale because it has not had activity for quite some time.Has this issue been fixed, or does it still require attention?

This issue will be closed in 15 days if no further activity occurs.

Thank you for your contributions.

github-actions[bot] avatar May 02 '24 10:05 github-actions[bot]

Marking this as something to fix for next breaking change.

russellwheatley avatar Aug 13 '24 14:08 russellwheatley