invertase
#166 Implement apple web based authentication using react native WebView.
Can you please review it and let me know if this will work for this module.
@Romick2005 thanks for that change - this looks pretty cool as I read it. Are you using this in your app / can you attest that this works for you exactly as is ?
@Romick2005 thanks for that change - this looks pretty cool as I read it. Are you using this in your app / can you attest that this works for you exactly as is ?
Yes it is working for me. Should I create some tests or examples?
Implementing it in the example app itself is the gold standard - I suppose that may not be possible without my help in order to get the SHA and everything configured correctly? If you implemented it there so that it was working for everything except those bits I can work that out so that it works out of the box I think, then it serves as the test too (it's what I use to test larger PRs, anyway)
@mikehardy I add examples, but I have no chance to test them. Would be good if you could test it on your side. Please let me know if I need to complete anything for this pull request.
@Romick2005 thank you for your patience! I was travelling which cause a delay in this. It appears the CLA is still not signed, so I won't be able to integrate this yet. Could you follow the CLA instructions and sign it please? Thank you!
Not that I'm aware of - it's just holiday time and I have a small child so I'm not working very much
Looking forward to this PR integration. Having Apple Sign-In on iOS < 13 would be a great addition. End-users are surprised to have it on Android even before all iOS versions.
Very sorry :-), one of my projects (https://github.com/ankidroid/Anki-Android/) was selected to participate in Google Summer of Code and we had literally 50 people show up and start posting PRs all at once. I got 500 notifications in a week :sweat_smile: - it has taken almost all of my volunteer time.
I really appreciate your patience - it will happen, hopefully soon, I'm nearly caught up again despite the torrent of PRs in the other project
We would really like to see this, too. Anything we can do to help @mikehardy?
@Romick2005 can you update the fork/branch to resolve the merge conflicts?
I rebased it and pushed the result to https://github.com/invertase/react-native-apple-authentication/pull/335 - it needs testing, and I believe there are comments here that were not addressed
The way to move this forward is to test it, as mentioned on https://github.com/invertase/react-native-apple-authentication/pull/335, and to look at any of my old comments here and resolve them
Would be cool to see it go in