flutterfire_cli icon indicating copy to clipboard operation
flutterfire_cli copied to clipboard

[bug]: Package name length limited

Open rayliverified opened this issue 1 year ago • 7 comments

Is there an existing issue for this?

  • [X] I have searched the existing issues.

CLI Version

1.0.0

Firebase Tools version

13.20.2

Flutter Doctor Output

[√] Flutter (Channel beta, 3.26.0-0.1.pre, on Microsoft Windows [Version 10.0.22631.4169], locale en-US) • Flutter version 3.26.0-0.1.pre on channel beta at C:\Users\searc\Development\flutter • Upstream repository https://github.com/flutter/flutter.git • Framework revision ee624bc4fd (3 weeks ago), 2024-09-10 17:41:06 -0500 • Engine revision 059e4e6d8f • Dart version 3.6.0 (build 3.6.0-216.1.beta) • DevTools version 2.39.0

[√] Windows Version (Installed version of Windows is version 10 or higher)

[√] Android toolchain - develop for Android devices (Android SDK version 35.0.0) • Android SDK at C:\Users\searc\AppData\Local\Android\sdk • Platform android-35, build-tools 35.0.0 • Java binary at: C:\Program Files\Android\Android Studio\jbr\bin\java • Java version OpenJDK Runtime Environment (build 17.0.10+0--11609105) • All Android licenses accepted.

[X] Chrome - develop for the web (Cannot find Chrome executable at .\Google\Chrome\Application\chrome.exe) ! Cannot find Chrome. Try setting CHROME_EXECUTABLE to a Chrome executable.

[√] Visual Studio - develop Windows apps (Visual Studio Community 2022 17.7.5) • Visual Studio at C:\Program Files\Microsoft Visual Studio\2022\Community • Visual Studio Community 2022 version 17.7.34202.233 • Windows 10 SDK version 10.0.22621.0

[√] Android Studio (version 2024.1) • Android Studio at C:\Program Files\Android\Android Studio • Flutter plugin can be installed from: https://plugins.jetbrains.com/plugin/9212-flutter • Dart plugin can be installed from: https://plugins.jetbrains.com/plugin/6351-dart • Java version OpenJDK Runtime Environment (build 17.0.10+0--11609105)

[√] VS Code (version 1.93.1) • VS Code at C:\Users\searc\AppData\Local\Programs\Microsoft VS Code • Flutter extension version 3.96.0

[√] Connected device (2 available) • Windows (desktop) • windows • windows-x64 • Microsoft Windows [Version 10.0.22631.4169] • Edge (web) • edge • web-javascript • Microsoft Edge 129.0.2792.65

[√] Network resources • All expected network resources are available.

Description

flutterfire_cli package name input is limited. Cannot enter full package name.

https://github.com/user-attachments/assets/ebcd85c8-00c3-440e-9ec9-a82eb2515087

https://github.com/user-attachments/assets/e6f01ba6-f6f2-4952-8578-8a4cfc3ddf0e

Steps to reproduce

  1. Run flutterfire configure
  2. Type a package name that reached the length of the terminal window.

Expected behavior

Package name length should not be limited.

Screenshots

No response

Additional context and comments

No response

rayliverified avatar Oct 03 '24 15:10 rayliverified

this issue can be closed

IldySilva avatar Oct 11 '24 22:10 IldySilva

Still seeing the issue. Is there an updated CLI?

rayliverified avatar Oct 11 '24 23:10 rayliverified

This is a huge problem, especially given the restricted terminal width inside of VSCode; if you're doing a copy/paste, there is a big chance that the user doesn't even notice that their package name has been cut off, thereby rendering the output worthless with no feedback to the user as to what the problem was. Without a close examination of the console output and/or the results in the Firebase Console, this issue is impossible to discover.

csells avatar Oct 14 '24 18:10 csells

@rayliverified The flutterfire_cli relies on the interact package for handling console input. A related issue has been documented in the interact package repository under frencojobs/interact#18.

being-eyram avatar Nov 04 '24 11:11 being-eyram

Hello 👋, to help manage issues we automatically close stale issues.

This issue has been automatically marked as stale because it has not had activity for quite some time.Has this issue been fixed, or does it still require attention?

This issue will be closed in 15 days if no further activity occurs.

Thank you for your contributions.

github-actions[bot] avatar Dec 02 '24 12:12 github-actions[bot]

Hi Github Bot, the issue persists so it should remain open 👋

rayliverified avatar Dec 02 '24 19:12 rayliverified

As mentioned by @being-eyram, this is an issue with underlying interact package, as a workaround for now, you can add the package name directly as an argument:

flutterfire configure --android-package-name=com.some.application

russellwheatley avatar Jan 15 '25 11:01 russellwheatley