flutterfire_cli icon indicating copy to clipboard operation
flutterfire_cli copied to clipboard

fix: Remove throwing an exception if appId/bundleId is not provided

Open AhmedLSayed9 opened this issue 2 years ago โ€ข 2 comments

Description

If a platform's appId/bundleId is not provided, an exception will be thrown inside a CI environment.

There was a partial fix for the mandatory flag by https://github.com/invertase/flutterfire_cli/pull/179 but it's not completely fixed as an exception will still be thrown:

This should fix https://github.com/invertase/flutterfire_cli/issues/233

Type of Change

  • [ ] โœจ feat -- New feature (non-breaking change which adds functionality)
  • [x] ๐Ÿ› ๏ธ fix -- Bug fix (non-breaking change which fixes an issue)
  • [ ] โŒ ! -- Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] ๐Ÿงน refactor -- Code refactor
  • [ ] โœ… ci -- Build configuration change
  • [ ] ๐Ÿ“ docs -- Documentation
  • [ ] ๐Ÿ—‘๏ธ chore -- Chore

AhmedLSayed9 avatar Nov 21 '23 04:11 AhmedLSayed9

@russellwheatley can you review it ?

FloLecoeuche avatar Dec 27 '23 08:12 FloLecoeuche

@russellwheatley Can you check this PR, please?

AhmedLSayed9 avatar Mar 20 '24 17:03 AhmedLSayed9

Closed in favour of: https://github.com/invertase/flutterfire_cli/pull/276

russellwheatley avatar Apr 11 '24 12:04 russellwheatley