dart_firebase_admin icon indicating copy to clipboard operation
dart_firebase_admin copied to clipboard
verified publisher icon invertase

Use HTTP codes to determine MessagingClientErrorCode

Open kmcgill88 opened this issue 2 years ago • 2 comments

https://github.com/invertase/dart_firebase_admin/issues/22

@rrousselGit looking for some feedback on this. If y'all agree on the direction I will add tests.

  • I cut down on the amount of MessagingClientErrorCode. Felt like some were duplicated.
  • Added int? httpStatusCode to MessagingClientErrorCode.
  • Added more docs from Firebase docs.

kmcgill88 avatar Feb 09 '24 15:02 kmcgill88

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Feb 09 '24 15:02 CLAassistant

Could a contributor please provide some feedback on this? I've been using this is a production environment successfully for weeks now.

kmcgill88 avatar Mar 06 '24 21:03 kmcgill88

@lesnitsky @Ehesp I'd love to get feedback on this and come to a conclusion. Thanks!

kmcgill88 avatar May 24 '24 01:05 kmcgill88

Closed in favour of https://github.com/invertase/dart_firebase_admin/pull/43

Thanks for this though! It helped a lot to understand the problem :)

rrousselGit avatar Jul 15 '24 10:07 rrousselGit

Closed in favour of #43

Thanks for this though! It helped a lot to understand the problem :)

What exactly is the problem?

kmcgill88 avatar Jul 15 '24 13:07 kmcgill88