inveniosoftware
is_url: allow urls with parameters
:heart: Thank you for your contribution!
Description
Software heritage uses urls with parameters, like https://archive.softwareheritage.org/swh:1:dir:44ac666e75004dd2a27ca0e09e73aecc0e8b426f;origin=https://github.com/amykwebster/MIPseq_2021;visit=swh:1:snp:46bcbe75339295c3d68fcf1257022aae8e6bee40;anchor=swh:1:rev:27839dcc9ef1587086be195349310fb70fbfcaf1 . However the idutils is_url function will reject these as not being a valid url.
This PR makes the is_url function more permissive. Software heritage ids and related urls are already in idutils, so it's a bit odd for idutlils to say that they aren't urls.
Checklist
Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:
- [x] I'm aware of the code of conduct.
- [x] I've created logical separate commits and followed the commit message format.
- [x] I've added relevant test cases.
- [ ] I've added relevant documentation.
- [ ] I've marked translation strings (for relevant code).
- [ ] I've followed the CSS/JS and React guidelines (for relevant code).
- [ ] I've followed the web accessibility guidelines (for relevant code).
- [ ] I've followed the user interface guidelines (for relevant code).
- [ ] I've identified the copyright holder(s) and updated copyright headers for touched files (>15 lines contributions).
- [x] I've NOT included third-party code (copy/pasted source code or new dependencies).
Third-party code
If you've added third-party code (copy/pasted or new dependencies), please reach out to an architect.
Reminder
By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:
- You license your contribution under the same terms as the current repository’s license.
- You agree that you have the right to license your contribution under the current repository’s license.
It is useful to link to software directly with a SWHID. SWHID with parameters are more useful from the core SWHID without parameters.
#OR2024
